Repository navigation
Docs: refuse modules that depend on another module - #616
Merged
Merged
Conversation
Every module must build, install and work when it is the only module chosen. State it in AGENTS.md, the module guides' cross-compatibility section, ADD_A_MODULE.md, CONTRIBUTING.md and the pull request template: no requires, no hooks into another module, no "needs X" selection rule, no stacked module pull requests, no exception. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires, a "needs FM Synth" selection rule and shared-code changes to make that work. Related to SY DRUM 0.1.0: a new machine module (needs FM Synth; stacked on the FM Synth 0.1.5 PR) #558.requires; no "needs X" selection rule; no module PR stacked on another's. Shared code goes into the base or shared SDK first (its own owner-reviewed PR), or both features ship as one module. No exception entry covers it.AGENTS.md: a "Refuse a module that depends on another module" bullet beside the protected-work one.docs/module-guides/README.md: the full rule at the top of Cross-compatibility (the bullets link here).docs/ADD_A_MODULE.md(Rules that always apply),CONTRIBUTING.md(what review expects),.github/pull_request_template.md(a checkbox).sdk/octabam/platform/*) still userequiresamong themselves; the rule is about modules. Conflicts (two modules that cannot be chosen together, for a named reason) stay allowed.npm run check -- --base origin/main(documentation path): passed, 269 catalogue tests.🤖 Generated with Claude Code